Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing permission for horologium and bump prow images to latest #2026

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

codificat
Copy link
Member

Related Issues and Dependencies

#2025

Does this require new deployment ?

No

Description

There was a breaking change in horologium that required additional watch permissions on ProwJobs. This can be seen in its pod logs:

E1011 11:39:56.742388       1 reflector.go:138] external/io_k8s_client_go/tools/cache/reflector.go:167: Failed to watch *v1.ProwJob: unknown (get prowjobs.prow.k8s.io)

This adds this permission.

Additionally, this bumps all the images to the latest version available (v20211008-8c358bcb9d)

@sesheta sesheta requested review from fridex and pacospace October 11, 2021 12:40
@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 11, 2021
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@sesheta
Copy link
Member

sesheta commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@sesheta sesheta merged commit 620fa5a into thoth-station:master Oct 11, 2021
@sesheta sesheta added this to the 2021.10.11 milestone Oct 11, 2021
@codificat codificat deleted the prow-bump-versions branch October 11, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants