Fix Locals need to be shallow cloned. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kortirso this should fix the issue you're having. Would you like me to add you as co-author as I used your reproduction branch? If so, which email would you like me to use? Let me know, i can push out a release same day. |
I can make PR with test, so there will be some kind of history :) |
Resolves #20. `prop_template` prebuilds an array of options before handling it off to handle_collection to build. I recall this being somewhat related to faster collection rendering. Unfortunately, the trade off is that we have to be cognizant of how we mutate deeply nested options as those can be the same object. In this case, I missed a required clone on locals.
jho406
force-pushed
the
fix-options-not-being-cloned
branch
from
155d99b to
f19fc55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20.
prop_templateprebuilds an array of options before handling it off to handle_collection to build. I recall this being somewhat related to faster collection rendering. Unfortunately, the trade off is that we have to be cognizant of how we mutate deeply nested options as those can be the same object. In this case, I missed a required clone on locals.