Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and improve README.md #41

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

Uaitt
Copy link
Contributor

@Uaitt Uaitt commented Jan 2, 2025

While reading the README of this project I spotted some typos and some places where the wording could be improved :)

@Uaitt Uaitt requested a review from jho406 as a code owner January 2, 2025 09:22
@@ -100,7 +100,7 @@ json.set! :authorDetails, {...options} do
json.set! :firstName, 'David'
end

or
# or
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In code snippets like this, if non-ruby code is not commented it will mess up the syntax highligting:
Screenshot 2025-01-02 at 10 23 31

@jho406
Copy link
Contributor

jho406 commented Jan 3, 2025

Welcome! This looks solid! Thanks so much @Uaitt

@jho406 jho406 merged commit 93fc652 into thoughtbot:main Jan 3, 2025
13 checks passed
@Uaitt Uaitt deleted the improve-readme branch January 3, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants