Use Ruby function shorthand and apply standard linting (#376)

**This PR:**
- Implements Ruby shorthand for method calls (e.g., `new(method:)
instead of new(method: method)`
- Applies linting via [Standard
Ruby](https://github.com/standardrb/standard)

README.md

@@ -36,7 +36,7 @@ You can create static filters that always run the same query:
 ```ruby
 input = Yuriita::Inputs::Expression.new("is", "published")
 
-Yuriita::ExpressionFilter.new(input: input) do |relation|
+Yuriita::ExpressionFilter.new(input:) do |relation|
   relation.where(published: true)
 end
 ```

Rakefile

@@ -1,8 +1,7 @@
-require File.expand_path('../spec/example_app/config/application', __FILE__)
+require File.expand_path("../spec/example_app/config/application", __FILE__)
 
 Bundler::GemHelper.install_tasks
 
-
 Rails.application.load_tasks
 
 task(:default).clear
@@ -15,4 +14,4 @@ if defined? RSpec
   end
 end
 
-task :default => :spec
+task default: :spec

lib/yuriita/assembler.rb

@@ -8,7 +8,7 @@ def initialize(configuration)
 
     def build(query)
       configuration.map do |definition|
-        definition.apply(query: query)
+        definition.apply(query:)
       end
     end
   end

lib/yuriita/clauses/filter.rb

@@ -8,7 +8,7 @@ def initialize(filters:, combination:)
 
       def apply(relation)
         relations = filters.map { |filter| filter.apply(relation) }
-        combination.new(base_relation: relation, relations: relations).combine
+        combination.new(base_relation: relation, relations:).combine
       end
 
       private

lib/yuriita/clauses/search.rb

@@ -9,7 +9,7 @@ def initialize(filters:, keywords:, combination:)
 
       def apply(relation)
         relations = filters.map { |filter| filter.apply(relation, keywords) }
-        combination.new(base_relation: relation, relations: relations).combine
+        combination.new(base_relation: relation, relations:).combine
       end
 
       private

lib/yuriita/collection.rb

@@ -31,21 +31,20 @@ def dispatch(name, relation)
 
     private
 
-    def process(action, *args)
+    def process(action, *)
       action = action.to_s
 
-      unless method_name = find_method_name(action)
+      unless (method_name = find_method_name(action))
         raise ActionNotFound.new("The action '#{action}' could not be found for #{self.class.name}", self, action)
       end
 
-      process_action(method_name, *args)
+      process_action(method_name, *)
     end
 
-    def process_action(method_name, *args)
-      send_action(method_name, *args)
+    def process_action(method_name, *)
+      send_action(method_name, *)
     end
-    alias send_action send
-
+    alias_method :send_action, :send
 
     def find_method_name(action)
       if action_method?(action)

lib/yuriita/definitions/dynamic.rb

@@ -9,7 +9,7 @@ def apply(query:)
         input = select_input(query)
 
         if input.present?
-          Clauses::Dynamic.new(filter: filter, input: input)
+          Clauses::Dynamic.new(filter:, input:)
         else
           Clauses::Identity.new
         end

lib/yuriita/definitions/exclusive.rb

@@ -11,7 +11,7 @@ def initialize(options:, default:)
       def apply(query:)
         filter = selected_filter(query)
 
-        Clauses::Filter.new(filters: [filter], combination: combination)
+        Clauses::Filter.new(filters: [filter], combination:)
       end
 
       private
@@ -22,9 +22,9 @@ def combination
 
       def selected_filter(query)
         Selects::Exclusive.new(
-          options: options,
-          default: default,
-          query: query,
+          options:,
+          default:,
+          query:
         ).filter
       end
     end

lib/yuriita/definitions/multiple.rb

@@ -12,7 +12,7 @@ def apply(query:)
         filters = selected_filters(query)
 
         if filters.present?
-          Clauses::Filter.new(filters: filters, combination: combination)
+          Clauses::Filter.new(filters:, combination:)
         else
           Clauses::Identity.new
         end
@@ -21,7 +21,7 @@ def apply(query:)
       private
 
       def selected_filters(query)
-        Selects::Multiple.new(options: options, query: query).filters
+        Selects::Multiple.new(options:, query:).filters
       end
     end
   end

lib/yuriita/definitions/scope.rb

@@ -14,9 +14,9 @@ def apply(query:)
 
         if keywords.present?
           Clauses::Search.new(
-            filters: filters,
-            keywords: keywords,
-            combination: combination,
+            filters:,
+            keywords:,
+            combination:
           )
         else
           Clauses::Identity.new
@@ -26,7 +26,7 @@ def apply(query:)
       private
 
       def selected_filters(query)
-        Selects::AllOrExplicit.new(options: options, query: query).filters
+        Selects::AllOrExplicit.new(options:, query:).filters
       end
     end
   end

lib/yuriita/definitions/single.rb

@@ -11,7 +11,7 @@ def apply(query:)
         filter = selected_filter(query)
 
         if filter.present?
-          Clauses::Filter.new(filters: [filter], combination: combination)
+          Clauses::Filter.new(filters: [filter], combination:)
         else
           Clauses::Identity.new
         end
@@ -24,7 +24,7 @@ def combination
       end
 
       def selected_filter(query)
-        Selects::Single.new(options: options, query: query).filter
+        Selects::Single.new(options:, query:).filter
       end
     end
   end

lib/yuriita/errors/collection/action_not_found.rb

@@ -8,7 +8,6 @@ def initialize(message = nil, collection = nil, action = nil)
         @action = action
         super(message)
       end
-
     end
   end
 end

lib/yuriita/or_combination.rb

@@ -20,4 +20,3 @@ def combined_relations
     end
   end
 end
-

lib/yuriita/query.rb

@@ -13,7 +13,7 @@ def ==(other)
     end
 
     def keywords
-      inputs.select{ |input| input.is_a?(Yuriita::Inputs::Keyword) }
+      inputs.select { |input| input.is_a?(Yuriita::Inputs::Keyword) }
     end
 
     def each(&block)
@@ -26,7 +26,7 @@ def add_input(input)
       inputs << input
       self
     end
-    alias << add_input
+    alias_method :<<, :add_input
 
     def delete(input)
       inputs.delete(input)
@@ -42,7 +42,7 @@ def delete_if
     def size
       inputs.size
     end
-    alias length size
+    alias_method :length, :size
 
     def initialize_dup(original)
       super

lib/yuriita/router.rb

@@ -9,7 +9,7 @@ def append_route(collection, matcher, to:)
     end
 
     def route(input, relation)
-      if route = match_for(input)
+      if (route = match_for(input))
         collection = route.collection
         collection.dispatch(route.action, input, relation)
       end

lib/yuriita/search_filter.rb

@@ -15,7 +15,7 @@ def apply(relation, keywords)
 
       combination.new(
         base_relation: relation,
-        relations: relations,
+        relations:
       ).combine
     end
 

spec/example_app/Rakefile

@@ -1,6 +1,6 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require_relative 'config/application'
+require_relative "config/application"
 
 Rails.application.load_tasks

spec/example_app/app/controllers/documentation_controller.rb

@@ -30,6 +30,6 @@ def parse_document(path)
   end
 
   def render_not_found
-    raise ActionController::RoutingError, 'Not Found'
+    raise ActionController::RoutingError, "Not Found"
   end
 end

spec/example_app/app/controllers/movies_controller.rb

@@ -1,7 +1,7 @@
 class MoviesController < ApplicationController
   def index
     table = build_table
-    render locals: { table: table }
+    render locals: {table:}
   end
 
   private

spec/example_app/app/models/genre_sync.rb

@@ -1,6 +1,6 @@
 class GenreSync
   def self.run(client:)
-    new(client: client).run
+    new(client:).run
   end
 
   def initialize(client:)