-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date range query to cyberstorm API #1043
Open
Oksamies
wants to merge
1
commit into
master
Choose a base branch
from
cyberstorm-listing-date-filters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Oksamies
force-pushed
the
cyberstorm-listing-date-filters
branch
3 times, most recently
from
June 20, 2024 08:00
e5ae167
to
7432118
Compare
This was referenced Jun 24, 2024
This was referenced Jul 18, 2024
Oksamies
force-pushed
the
cyberstorm-listing-date-filters
branch
from
August 20, 2024 14:13
7432118
to
9e4cf1f
Compare
Oksamies
force-pushed
the
cyberstorm-listing-date-filters
branch
from
September 10, 2024 11:21
9e4cf1f
to
9121bea
Compare
/api/cyberstorm/listing/{community-id}/ now supports the query parameters updated_before, updated_after, created_before, and created_after.
assert result["count"] == 2 | ||
|
||
response = api_client.get( | ||
f"/api/cyberstorm/listing/{community.identifier}/??updated_recent=999", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the URL - it contains two question marks (??
) instead of one. The correct URL should be:
f"/api/cyberstorm/listing/{community.identifier}/?updated_recent=999"
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/cyberstorm/listing/{community-id}/ now supports the query parameters updated_before, updated_after, created_before, and created_after.