-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyberstorm api create team (TS-2312) #1101
Open
Roffenlund
wants to merge
5
commits into
master
Choose a base branch
from
cyberstorm-api-create-team
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roffenlund
commented
Feb 17, 2025
- Implemented CyberstormCreateTeamSerializer
- Added validation for the name field.
- Ensured service accounts cannot create teams.
- Moved serializers from the team views file to the serializers file.
- Implemented TeamCreateAPIView for handling new team creation in the Cyberstorm API.
x753
reviewed
Feb 17, 2025
x753
reviewed
Feb 17, 2025
1a3b0b8
to
989d0d1
Compare
x753
approved these changes
Feb 18, 2025
- Implement serializer for creating new teams. - Add validation for the name field. - Add non-field validation to prevent service accounts from creating teams. - Move serializers from the team views file to the serializers file. Refs. TS-2312
Implement CreateAPIView for creating new teams in the Cyberstorm API. Refs. TS-2312
Refs. TS-2312
Refs. TS-2312
Refs. TS-2312
989d0d1
to
6528394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.