build(deps): bump angular to 15 #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Angular/Material and related dependencies to 15. Using legacy material components for now to ease the upgrade process. This required changing the imports to the Legacy Material modules, removing the `appearance="legacy"` attribute from `mat-form-field` and specifying legacy styling in the demo theme. Angular 15 now requires a es target of `2022` in tsconfig.json. Tests ain't running yet. Final problem to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This library isn't working for Angular 15. Styling is messed up and causes some runtime errors.
Related to #244.
Reason for using Legacy Material instead of the latest MDC update
This is up to the author of the application, but I feel as a first update step,
v14.0.0should support just the legacy material components, and thenv16.0.0can drop the legacy support for the latest MDC components.Summary of changes
Updated Angular/Material and related dependencies to 15. Using legacy material components for now to ease the upgrade process. This required changing the imports to the Legacy Material modules, removing the
appearance="legacy"attribute frommat-form-fieldand specifying legacy styling in the demo theme.Angular 15 now requires a es target of
2022in tsconfig.json. This caused a few runtime errors where class variable initialisers were trying to reference constructor dependencies when they weren't defined yet.Tests ain't running yet. Final problem to fix.