VanGoghBoard/FspsWrapperPeim: Prevent null pointer dereference #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
requested review from
abdattar,
changab,
exinghr and
pbgrimes
as code owners
Return from FspsWrapperInitDispatchMode() if a buffer allocation fails instead of attempting to dereference the pointer. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
intelfsp2wrapper_codeql
branch
from
90a20c3 to
818c497
Compare
|
@abdattar, @changab, @exinghr, @pbgrimes I noticed this PR has set stale for a while. The equivalent edk2 PR (tianocore/edk2#6250) is now merged and I've rebased this one for review. |
abdattar
approved these changes
Jan 17, 2025
|
Thanks for the reviews. Please merge when you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return from FspsWrapperInitDispatchMode() if a buffer allocation fails instead of attempting to dereference the pointer.
Note: This is bringing a change going into the original edk2 file here into this forked copy of the module.