SbsaQemu: fix FWTS errors #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leiflindholm
reviewed
Oct 9, 2024
leiflindholm
reviewed
Oct 9, 2024
Change MemoryAccessFlags field to indicate IO coherency is supported. FWTS 'iort' test said: FAILED [HIGH] IORTMemAttrInvalid: Test 1, IORT PCI Root Complex Node Memory Attributes are illegal, CCA cannot be 1 if CPM is 0. We have memory coherency with the CPU cache hierarchy. Signed-off-by: Marcin Juszkiewicz <[email protected]>
Our table was done for old version of specification. Signed-off-by: Marcin Juszkiewicz <[email protected]>
We were saying "SMBIOS 3.4" but structure sizes were from 3.7 one so FWTS complained: FAILED [HIGH] DMIBadTableLength: Test 3, Type 17 expects length of 0x5c, has incorrect length of 0x64 Added all missing fields as well. Signed-off-by: Marcin Juszkiewicz <[email protected]>
leiflindholm
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran FirmWare Test Suite and it gave me two errors:
This branch fixes both of them. Also updates IORT to E.f version of specification.