Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicTablesPkg: Adds X64 FACS generator library #10577

Merged
merged 1 commit into from
Jan 24, 2025
Merged

DynamicTablesPkg: Adds X64 FACS generator library #10577

merged 1 commit into from
Jan 24, 2025

Conversation

abdattar
Copy link
Contributor

@abdattar abdattar commented Jan 1, 2025

Adds a library to generate ACPI FACS table for X64.

Cc: Sami Mujawar [email protected]
Cc: Pierre Gondois [email protected]

Description

Adds X64 generator library for creating ACPI FACS table.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Tested on AMD platform.

Integration Instructions

N/A

pierregondois
pierregondois reviewed Jan 3, 2025
View reviewed changes
DynamicTablesPkg/Include/AcpiTableGenerator.h Show resolved Hide resolved
DynamicTablesPkg/Library/Acpi/X64/AcpiFacsLib/FacsGenerator.c Show resolved Hide resolved
DynamicTablesPkg/Library/Acpi/X64/AcpiFacsLib/FacsGenerator.c Outdated Show resolved Hide resolved
DynamicTablesPkg/Library/Acpi/X64/AcpiFacsLib/FacsGenerator.c Outdated Show resolved Hide resolved
DynamicTablesPkg/Library/Acpi/X64/AcpiFacsLib/FacsGenerator.c Show resolved Hide resolved
DynamicTablesPkg/Include/X64NameSpaceObjects.h Outdated Show resolved Hide resolved
DynamicTablesPkg/Library/Acpi/X64/AcpiFacsLib/FacsGenerator.c Show resolved Hide resolved
DynamicTablesPkg/Library/Acpi/X64/AcpiFacsLib/FacsGenerator.c Outdated Show resolved Hide resolved
DynamicTablesPkg/Include/X64NameSpaceObjects.h Outdated Show resolved Hide resolved
DynamicTablesPkg/Library/Acpi/X64/AcpiFacsLib/FacsGenerator.c Show resolved Hide resolved
@abdattar abdattar force-pushed the Facs branch 3 times, most recently from 4dc2272 to f15d738 Compare January 17, 2025 06:43
@abdattar
Copy link
Contributor Author

Hi @pierregondois ,
Thanks for the quick follow-up review.
I have made the necessary changes based on your feedback.
Please take a look at it again.
Thank you
AbduL

@pierregondois
Copy link
Contributor

Hello Abdul,
The following commit effectively takes into account the Dsdt and removes the global lock:

But it doesn't seem to be the branch you pushed for the PR. Is it possible to check the branch you submitted ? Or maybe I did a mismanipulation

@abdattar
Copy link
Contributor Author

Sorry @pierregondois,
Looks like I have overwritten old "Facs" branch with new one with force push.
Not sure how I can revert to old branch, but i do have a copy of old branch on my local system.
Do you want me to push the old branch?
Thanks
AbduL

@pierregondois
Copy link
Contributor

Sorry @pierregondois, Looks like I have overwritten old "Facs" branch with new one with force push. Not sure how I can revert to old branch, but i do have a copy of old branch on my local system. Do you want me to push the old branch? Thanks AbduL

Please submit the branch that you would like to be accepted. I cannot make comments on the old versions of the PR

@abdattar
Copy link
Contributor Author

Sorry for the inconvenience, I have pushed the correct branch with correct patch set.

pierregondois
pierregondois approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@pierregondois pierregondois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Adbul,
Thanks for the modifications !

@pierregondois
Copy link
Contributor

Hello @abdattar ,
Would it be possible to rebase your branch on the latest master ?

DynamicTablesPkg: Adds X64 FACS generator library
8c25271 
Adds a library to generate the ACPI FACS table for X64 architecture.
It gathers the necessary FACS information from the configuration manager.
Additionally, it includes an event to update the hardware signature
in the FACS table, where the hardware signature is the
CRC of all ACPI table's CRC

Cc: Sami Mujawar <[email protected]>
Cc: Pierre Gondois <[email protected]>
Signed-off-by: Abdul Lateef Attar <[email protected]>
@abdattar
Copy link
Contributor Author

Hi @pierregondois ,
Rebase and submitted the patch.
Thanks
AbduL

@pierregondois pierregondois merged commit eda58c1 into tianocore:master Jan 24, 2025
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierregondois pierregondois pierregondois approved these changes

@samimujawar samimujawar Awaiting requested review from samimujawar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdattar @pierregondois