NetworkPkg/WifiConnectionManagerDxe: Keep Setup page on no Wi-Fi module #6515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ajfish,
leiflindholm,
mdkinney,
SaloniKasbekar and
Zclarkwilliams
With the driver, "Wi-Fi Configuration" Setup page is available regardless of Wi-Fi module existence. When there is no Wi-Fi module, it is found that entering the page causes exiting Setup browser. User would think the result as an error. For better user experience, the update enables the page to report the module status like a blank page. It prevents exiting Setup. Signed-off-by: Phil Noh <[email protected]>
|
Hi Maintainers (@ajfish, @leiflindholm, @mdkinney, @SaloniKasbekar, @Zclarkwilliams), Could you please help to review this PR that was requested on 12/6 ? Thank you. |
Zclarkwilliams
approved these changes
Dec 18, 2024
mdkinney
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the driver, "Wi-Fi Configuration" Setup page is available regardless of Wi-Fi module existence. When there is no Wi-Fi module, it is found that entering the page causes exiting Setup browser. User would think the result as an error. For better user experience, the update enables the page to report the module status like a blank page. It prevents exiting Setup.
How This Was Tested
We had an issue that system exits setup unexpectedly when entering the Wifi Configuration page without connecting a Wifi module. It has been tested and verified on AMD platforms that include the update.
Integration Instructions
N/A