Adjust LoongArch exception handler and enable some base libraries on LoongArch VM #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚠ WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future. Non-collaborators requested: Attn Admins: Admin Instructions:
|
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
AydenMeng,
jiaxinwu,
jyao1,
kraxel,
LiuZhiguang001,
MarsDoge,
niruiyu,
rahul1-kumar,
td36 and
zhangbaoqi-ls
kilaterlee
force-pushed
the
Submit1217
branch
from
f22c442 to
4db4ea3
Compare
kilaterlee
force-pushed
the
Submit1217
branch
from
4db4ea3 to
8dbad64
Compare
MarsDoge
approved these changes
Dec 18, 2024
MarsDoge
approved these changes
Dec 18, 2024
AydenMeng
approved these changes
Dec 18, 2024
|
@ardbiesheuvel @niruiyu Hi Ard and Ray, please help to review these changes, THX! :) |
kilaterlee
force-pushed
the
Submit1217
branch
4 times, most recently
from
e991535 to
935364c
Compare
There is a problem with LoongArch64 exception handler, it returns a unhandled value when we get an exception type, the correct value should be right shifted 16 bits, so fix it. Cc: Ray Ni <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Zhiguang Liu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Jiaxin Wu <[email protected]> Signed-off-by: Chao Li <[email protected]>
If the exception type is INT, we need to know which interrupt could not be handled, so we added a method to dump them. Cc: Ray Ni <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Zhiguang Liu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Jiaxin Wu <[email protected]> Signed-off-by: Chao Li <[email protected]>
BaseCryptLib, RngLib, IntrinsicLib and OpensslLib are enabled by default on LoongArch VM, since some APPs or OS require them. Cc: Ard Biesheuvel <[email protected]> Cc: Jiewen Yao <[email protected]> Cc: Gerd Hoffmann <[email protected]> Signed-off-by: Chao Li <[email protected]>
kilaterlee
force-pushed
the
Submit1217
branch
from
935364c to
cd44da2
Compare
Hi @ardbiesheuvel and @niruiyu , ping to review :) |
niruiyu
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patch1: There is a problem with LoongArch64 exception handler, it returns a unhandled value when we get an exception type, the correct value should be right shifted 16 bits, so fix it. Increased the max number of exception handlers to 23.
Patch2: Added interrupt type dump function on LoongArch.
Patch3: BaseCryptLib, RngLib, IntrinsicLib and OpensslLib are enabled by default on LoongArch VM, since some APPs or OS require them.
How This Was Tested
Build OvmfPkg/LoongArchVirt/LoongArchVirtQemu.dsc and run it.
Integration Instructions
N/A.