Midimap+ #1284
Open
Midimap+ #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a second argument to the midi() command: mapping. This argument should be an object containing a key-value map of MIDI controls used by an external synthesizer. If any control is used that matches the mapping, a CC message is sent.
split sysex message into sysexid and sysexdata sysexid is a device identification number or array sysexdata is an array of data to be sent to the device
- add example sysex data for setting NSX-39(Pocket Miku) voice data.
…d-program-change
- MiniRepl for input-output.mdx - addresses tidalcycles#789 tidalcycles#710
- add progNum keyword handler - update midicmd handler to handle 'progNum' case
- sysex(id, data) and both arguments are patternable
- add mock 'midin' and 'sysex' - typo in sysex example
…d-program-change
- Move MIDI API logic into separate functions following tidalcycles#1274 (sendCC, sendProgramChange, sendPitchBend, etc.)
|
great, yes that was still missing from the midimap PR. so i guess we discuss / merge #1244 first, before looking at this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enables midimaps to register control names that are not limited to Strudel's controlNames.
This provides greater flexibility in customization while maintaining compatibility with existing mappings.
However, further consideration is needed regarding potential namespace pollution.
This PR includes updates from #1244