Revert "Attempted clearScreen() syncronisation fix"

This reverts commit f6584dd.
tidbyt · Aug 18, 2021 · e12eaf1 · e12eaf1
1 parent 3b13645
commit e12eaf1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp b/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp
@@ -532,9 +532,9 @@ void IRAM_ATTR MatrixPanel_I2S_DMA::updateMatrixDMABuffer(int16_t x_coord, int16
 
 
 /* Update the entire buffer with a single specific colour - quicker */
-bool MatrixPanel_I2S_DMA::updateMatrixDMABuffer(uint8_t red, uint8_t green, uint8_t blue)
+void MatrixPanel_I2S_DMA::updateMatrixDMABuffer(uint8_t red, uint8_t green, uint8_t blue)
 {
-  if ( !initialized ) return false;
+  if ( !initialized ) return;
 
 	/* https://ledshield.wordpress.com/2012/11/13/led-brightness-to-your-eye-gamma-correction-no/ */	 
 #ifndef NO_CIE1931
@@ -585,8 +585,6 @@ bool MatrixPanel_I2S_DMA::updateMatrixDMABuffer(uint8_t red, uint8_t green, uint
 
     } while(matrix_frame_parallel_row); // end row iteration
   } // colour depth loop (8)
-
-  return true;
 } // updateMatrixDMABuffer (full frame paint)
 
 /**

diff --git a/ESP32-HUB75-MatrixPanel-I2S-DMA.h b/ESP32-HUB75-MatrixPanel-I2S-DMA.h
@@ -422,10 +422,9 @@ class MatrixPanel_I2S_DMA {
     virtual void fillScreen(uint16_t color);                        // overwrite adafruit implementation
 
     /**
-     * A wrapper to fill whatever selected DMA buffer / screen with black.
-	 * Returns true when operation is completed for syncronisation reasons. 
+     * A wrapper to fill whatever selected DMA buffer / screen with black
      */
-    inline bool clearScreen(){ return updateMatrixDMABuffer(0,0,0); };
+    inline void clearScreen(){ updateMatrixDMABuffer(0,0,0); };
 
 #ifndef NO_FAST_FUNCTIONS
     /**
@@ -595,7 +594,7 @@ class MatrixPanel_I2S_DMA {
     void updateMatrixDMABuffer(int16_t x, int16_t y, uint8_t red, uint8_t green, uint8_t blue);
 
     /* Update the entire DMA buffer (aka. The RGB Panel) a certain colour (wipe the screen basically) */
-    bool updateMatrixDMABuffer(uint8_t red, uint8_t green, uint8_t blue);       
+    void updateMatrixDMABuffer(uint8_t red, uint8_t green, uint8_t blue);       
 
     /**
      * wipes DMA buffer(s) and reset all color/service bits