mdns: Fix potential null deref reported by fuzzer test

tidbyt · Feb 16, 2022 · c0e105c · c0e105c
1 parent 33f7009
commit c0e105c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c
@@ -2821,7 +2821,8 @@ static bool _mdns_question_matches(mdns_parsed_question_t * question, uint16_t t
     if (type == MDNS_TYPE_A || type == MDNS_TYPE_AAAA) {
         return true;
     } else if (type == MDNS_TYPE_PTR || type == MDNS_TYPE_SDPTR) {
-        if (!strcasecmp(service->service->service, question->service)
+        if (question->service && question->proto && question->domain
+            && !strcasecmp(service->service->service, question->service)
             && !strcasecmp(service->service->proto, question->proto)
             && !strcasecmp(MDNS_DEFAULT_DOMAIN, question->domain)) {
             return true;