Remove dependency on ellipsis #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Looking strong. I'm seeing: in our tests. Could you update this PR to address that warning and then I'll come back to review then? |
|
Appears that I forgot one. Sorry! About the tests failures, they might be because Matrix and or lme4 are not installed correctly. lme4/lme4#699 (comment) |
|
Yup, no worries on the Matrix and lme4 issues. I will troubleshoot that in a separate thread. :) |
simonpcouch
reviewed
Dec 5, 2023
|
This pull request has been automatically locked. If you believe the issue addressed here persists, please file a new PR (with a reprex: https://reprex.tidyverse.org) and link to this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ellipsis imports rlang anyway.
I also took the opportunity to remove duplicated package description. https://broom.tidymodels.org/reference/broom.html