Switch from rlang::abort() in parameters.R, grids.R and misc.R
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
changed the title
rlang::abort() in parameters.R, grids.R and misc.R.rlang::abort() in parameters.R, grids.R and misc.R
hfrick
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Woop! Bye bye paste0! 👋
Would you please add tests for the messages that don't have one yet? I spotted an instance where the call has not yet been threaded through and another one with a test missing and I assume there might be more that are still missing a test.
Comment on lines
+256
to
+258
| cli::cli_abort( | ||
| "{.arg x} must be a data frame to construct a new grid from." | ||
| ) |
There was a problem hiding this comment.
Can you thread the call through and give this message a test?
There was a problem hiding this comment.
I can thread through the call. but this code as far as I can seen isn't possible to reach naturally. It is only applied to the output of functions like make_max_entropy_grid() and make_latin_hypercube_grid() which returns
|
I went in add added the missing tests where i could find them |
hfrick
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #311
This PR changes
rlang::abort()tocli::cli_abort()inparameters.R,grids.Randmisc.R.