Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more cat() in printing methods #353

Merged
merged 8 commits into from
Sep 24, 2024
Merged

No more cat() in printing methods #353

merged 8 commits into from
Sep 24, 2024

Conversation

EmilHvitfeldt
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt commented Sep 20, 2024

ref: #311

This should end our cli conversion and close #311. I left a few comments to explain what I did

NEWS.md Show resolved Hide resolved
R/constructors.R Show resolved Hide resolved
R/parameters.R Outdated Show resolved Hide resolved
R/parameters.R Show resolved Hide resolved
tests/testthat/_snaps/constructors.md Show resolved Hide resolved
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A beauty! 💐

R/constructors.R Show resolved Hide resolved
R/parameters.R Show resolved Hide resolved
R/parameters.R Show resolved Hide resolved
R/parameters.R Outdated Show resolved Hide resolved
R/parameters.R Outdated Show resolved Hide resolved
R/parameters.R Outdated Show resolved Hide resolved
@hfrick hfrick merged commit e2465f6 into main Sep 24, 2024
11 checks passed
@hfrick hfrick deleted the no-more-cat branch September 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cli errors
3 participants