Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of expect_error() #360

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Update usage of expect_error() #360

merged 3 commits into from
Oct 21, 2024

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Oct 21, 2024

  • expect_error({expr}, NA) -> expect_no_condition()
  • removing tests on an error being thrown from base-R by UseMethod(), e.g.,
>     grid_max_entropy(
+       size = 11,
+       original = FALSE
+     )
Error in UseMethod("grid_max_entropy") : 
  no applicable method for 'grid_max_entropy' applied to an object of class "c('double', 'numeric')"

removing `expect_error()` on a baseR error from `UseMethod()`
removing `expect_error()` on a baseR error from `UseMethod()`
@hfrick hfrick requested a review from simonpcouch October 21, 2024 14:20
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nailed it!🎯

@hfrick hfrick merged commit d06ea83 into main Oct 21, 2024
11 checks passed
@hfrick hfrick deleted the expect_error branch October 21, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants