updates for no-suggests checks (#70)

* changes for hard "no suggests" checks

* new GHA

* fix a few tests

* remove redundant test

* more skips

.github/workflows/R-CMD-check-hard.yaml

@@ -0,0 +1,59 @@
+# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
+# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
+#
+# NOTE: This workflow only directly installs "hard" dependencies, i.e. Depends,
+# Imports, and LinkingTo dependencies. Notably, Suggests dependencies are never
+# installed, with the exception of testthat, knitr, and rmarkdown. The cache is
+# never used to avoid accidentally restoring a cache containing a suggested
+# dependency.
+on:
+  push:
+    branches: [main, master]
+  pull_request:
+
+name: R-CMD-check-hard.yaml
+
+permissions: read-all
+
+jobs:
+  check-no-suggests:
+    runs-on: ${{ matrix.config.os }}
+
+    name: ${{ matrix.config.os }} (${{ matrix.config.r }})
+
+    strategy:
+      fail-fast: false
+      matrix:
+        config:
+          - {os: ubuntu-latest,   r: 'release'}
+
+    env:
+      GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
+      R_KEEP_PKG_SOURCE: yes
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: r-lib/actions/setup-pandoc@v2
+
+      - uses: r-lib/actions/setup-r@v2
+        with:
+          r-version: ${{ matrix.config.r }}
+          http-user-agent: ${{ matrix.config.http-user-agent }}
+          use-public-rspm: true
+
+      - uses: r-lib/actions/setup-r-dependencies@v2
+        with:
+          dependencies: '"hard"'
+          cache: false
+          extra-packages: |
+            any::rcmdcheck
+            any::testthat
+            any::knitr
+            any::rmarkdown
+          needs: check
+
+      - uses: r-lib/actions/check-r-package@v2
+        with:
+          upload-snapshots: true
+          build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")'

DESCRIPTION

@@ -4,9 +4,9 @@ Version: 1.0.1.9000
 Authors@R: c(
     person("Emil", "Hvitfeldt", , "[email protected]", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0002-0679-1945")),
-    person("Max", "Kuhn", , "[email protected]", role = c("aut"),
+    person("Max", "Kuhn", , "[email protected]", role = "aut",
            comment = c(ORCID = "0000-0003-2402-136X")),
-    person(given = "Posit Software, PBC", role = c("cph", "fnd"))
+    person("Posit Software, PBC", role = c("cph", "fnd"))
   )
 Description: Bindings for additional classification models for use with
     the 'parsnip' package. Models include flavors of discriminant
@@ -34,6 +34,7 @@ Suggests:
     dplyr,
     earth,
     ggplot2,
+    hardhat,
     klaR,
     knitr,
     MASS,
@@ -47,12 +48,10 @@ Suggests:
     spelling,
     testthat (>= 3.0.0),
     xml2
-Config/Needs/website: 
-  tidymodels/tidymodels,
-  tidyverse/tidytemplate
+Config/Needs/website: tidymodels/tidymodels, tidyverse/tidytemplate
+Config/testthat/edition: 3
 Encoding: UTF-8
 Language: en-US
 LazyData: true
 Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.3.2
-Config/testthat/edition: 3

R/data.R

@@ -10,11 +10,13 @@
 #'
 #' @keywords datasets
 #' @examples
-#' data(parabolic)
+#' if (rlang::is_installed("ggplot2")) {
+#'   data(parabolic)
 #'
-#' library(ggplot2)
-#' ggplot(parabolic, aes(x = X1, y = X2, col = class)) +
-#'   geom_point(alpha = .5) +
-#'   theme_bw()
+#'   library(ggplot2)
+#'   ggplot(parabolic, aes(x = X1, y = X2, col = class)) +
+#'     geom_point(alpha = .5) +
+#'     theme_bw()
+#' }
 #'
 NULL

inst/WORDLIST

@@ -1,43 +1,26 @@
-al
+Ahdesmaki
 Buja
+CMD
 Codecov
-doi
-et
 Hastie
-klaR
 Lifecycle
-mda
-nonlinearly
-param
-pre
+ORCID
+PBC
 QDA
-quant
+RStudio
+Strimmer
 Tibshirani
 Yu
-cov
-fL
-frac
-laplace
+doi
+funder
+klaR
+mda
+modeldata
 naivebayes
-nprune
-num
-pmethod
+param
 psock
-Ahdesmaki
-Strimmer
+quant
+reprex
+sda
 sparsediscrim
-Bioinformatics
-Biometrics
-Dudoit
-Fridlyand
-Kubokawa
-Springer
-Srivistava
-Zhao
-backward'
-diagonal'
-naivebayes
-ORCID
-modeldata
 tidymodels
-funder

tests/testthat/_snaps/linear-lda.md

@@ -1,4 +1,4 @@
-# missing data
+# MASS::lda missing data
 
     Code
       f_pred <- predict(f_fit, glass_na, type = "prob")
@@ -11,7 +11,7 @@
 ---
 
     Code
-      exp_f_pred <- probs_to_tibble(predict(exp_f_fit, glass_na)$posterior)
+      exp_f_pred <- probs_to_tibble(predict(exp_f_fit_lda, glass_na)$posterior)
     Condition
       Warning in `FUN()`:
       no non-missing arguments to min; returning Inf

tests/testthat/_snaps/linear-sparsediscrim.md

@@ -1,4 +1,4 @@
-# lda_emp_bayes_eigen fit and prediction
+# sparsediscrim lda_emp_bayes_eigen fit and prediction
 
     'method' should be one of: 'diagonal', 'min_distance', 'shrink_cov', 'shrink_mean'
 

tests/testthat/_snaps/quad-qda.md

@@ -1,4 +1,4 @@
-# missing data
+# MASS::qda missing data
 
     Code
       f_pred <- predict(f_fit, penguins_miss, type = "prob")
@@ -28,29 +28,5 @@
 
 ---
 
-    Code
-      exp_f_pred <- probs_to_tibble(predict(exp_f_fit, penguins_miss)$posterior)
-    Condition
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
-      Warning in `FUN()`:
-      no non-missing arguments to min; returning Inf
+    no non-missing arguments to min; returning Inf
 

tests/testthat/_snaps/rda.md

@@ -1,4 +1,4 @@
-# printing
+# klaR::rda printing
 
     Code
       print(rda_spec)