expect_error(regex = NA) -> expect_snapshot()

tests/testthat/test-collapse_cart.R

@@ -3,7 +3,7 @@ test_that("collapsing factors", {
   data(ames, package = "modeldata")
   ames$Sale_Price <- log10(ames$Sale_Price)
 
-  expect_error(
+  expect_no_error(
     {
       rec_1 <-
         recipe(Sale_Price ~ ., data = ames) %>%
@@ -12,8 +12,7 @@ test_that("collapsing factors", {
           outcome = vars(Sale_Price)
         ) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_true(length(rec_1$steps[[1]]$results) == 1)
@@ -35,7 +34,7 @@ test_that("collapsing factors", {
     )
   )
 
-  expect_error(
+  expect_no_error(
     {
       rec_2 <-
         recipe(Sale_Price ~ ., data = ames) %>%
@@ -44,8 +43,7 @@ test_that("collapsing factors", {
           min_n = 100, cost_complexity = 0.1
         ) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_true(
@@ -60,7 +58,7 @@ test_that("failed collapsing", {
 
   # model fails
   ames$Sale_Price2 <- Inf
-  expect_error(
+  expect_no_error(
     {
       rec_3 <-
         recipe(Sale_Price2 ~ ., data = ames) %>%
@@ -69,14 +67,13 @@ test_that("failed collapsing", {
           outcome = vars(Sale_Price2)
         ) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_true(length(rec_3$steps[[1]]$results) == 0)
 
   # too many splits
-  expect_error(
+  expect_no_error(
     {
       rec_4 <-
         recipe(Sale_Price ~ ., data = ames) %>%
@@ -86,21 +83,19 @@ test_that("failed collapsing", {
           cost_complexity = 0, min_n = 1
         ) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_true(length(rec_4$steps[[1]]$results) == 0)
 
   # too many splits
-  expect_error(
+  expect_no_error(
     {
       rec_5 <-
         recipe(Sale_Price ~ ., data = ames) %>%
         step_collapse_cart(Central_Air, outcome = vars(Sale_Price)) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_true(length(rec_5$steps[[1]]$results) == 0)

tests/testthat/test-collapse_stringdist.R

@@ -4,14 +4,13 @@ test_that("collapsing factors", {
 
   data(ames, package = "modeldata")
 
-  expect_error(
+  expect_no_error(
     {
       rec_1 <-
         recipe(Sale_Price ~ ., data = ames) %>%
         step_collapse_stringdist(MS_SubClass, distance = 5) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_true(length(rec_1$steps[[1]]$results) == 1)
@@ -33,14 +32,13 @@ test_that("collapsing factors", {
     )
   )
 
-  expect_error(
+  expect_no_error(
     {
       rec_2 <-
         recipe(Sale_Price ~ ., data = ames) %>%
         step_collapse_stringdist(MS_SubClass, Overall_Cond, distance = 10) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_true(length(rec_2$steps[[1]]$results) == 2)
@@ -165,14 +163,13 @@ test_that("failed collapsing", {
   data(ames, package = "modeldata")
 
   # too many splits
-  expect_error(
+  expect_no_error(
     {
       rec_4 <-
         recipe(Sale_Price ~ ., data = ames) %>%
         step_collapse_stringdist(MS_SubClass, distance = 0) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_equal(
@@ -181,14 +178,13 @@ test_that("failed collapsing", {
   )
 
   # too few splits
-  expect_error(
+  expect_no_error(
     {
       rec_5 <-
         recipe(Sale_Price ~ ., data = ames) %>%
         step_collapse_stringdist(MS_SubClass, distance = 10000) %>%
         prep()
-    },
-    regex = NA
+    }
   )
 
   expect_equal(

tests/testthat/test-discretize_cart.R

@@ -17,7 +17,7 @@ mod <- rpart(y ~ x, data = sim_tr_reg)
 best_split <- unname(mod$splits[, "index"])
 
 test_that("low-level binning for classification", {
-  expect_error(
+  expect_no_error(
     splits <-
       embed:::cart_binning(
         sim_tr_cls$x,
@@ -26,8 +26,7 @@ test_that("low-level binning for classification", {
         cost_complexity = 0.01,
         tree_depth = 5,
         min_n = 10
-      ),
-    regexp = NA
+      )
   )
   expect_equal(splits, best_split)
 
@@ -47,7 +46,7 @@ test_that("low-level binning for classification", {
 })
 
 test_that("low-level binning for regression", {
-  expect_error(
+  expect_no_error(
     splits <-
       embed:::cart_binning(
         sim_tr_reg$x,
@@ -56,8 +55,7 @@ test_that("low-level binning for regression", {
         cost_complexity = 0.01,
         tree_depth = 5,
         min_n = 10
-      ),
-    regexp = NA
+      )
   )
   expect_equal(splits, best_split)
 
@@ -87,9 +85,8 @@ test_that("step function for classification", {
   expect_equal(names(cart_rec$steps[[1]]$rules), "x")
   expect_equal(cart_rec$steps[[1]]$rules$x, best_split)
 
-  expect_error(
-    cart_pred <- bake(cart_rec, sim_tr_cls[, -3]),
-    regexp = NA
+  expect_no_error(
+    cart_pred <- bake(cart_rec, sim_tr_cls[, -3])
   )
 
   expect_true(is.factor(cart_pred$x))
@@ -108,9 +105,8 @@ test_that("step function for regression", {
   expect_equal(names(cart_rec$steps[[1]]$rules), "x")
   expect_equal(cart_rec$steps[[1]]$rules$x, best_split)
 
-  expect_error(
-    cart_pred <- bake(cart_rec, sim_tr_reg[, -3]),
-    regexp = NA
+  expect_no_error(
+    cart_pred <- bake(cart_rec, sim_tr_reg[, -3])
   )
 
   expect_true(is.factor(cart_pred$x))

tests/testthat/test-embed.R

@@ -448,9 +448,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
 
-  expect_error(
-    bake(rec, new_data = ex_dat),
-    NA
+  expect_no_error(
+    bake(rec, new_data = ex_dat)
   )
 })
 

tests/testthat/test-feature_hash.R

@@ -10,7 +10,7 @@ test_that("basic usage", {
   rec <- recipe(x1 ~ x3, data = ex_dat) %>%
     step_feature_hash(x3)
 
-  expect_error(rec_tr <- prep(rec), regex = NA)
+  expect_no_error(rec_tr <- prep(rec))
 
   res_tr <- bake(rec_tr, new_data = NULL, dplyr::starts_with("x3"))
 
@@ -64,7 +64,7 @@ test_that("basic usage - character strings", {
   rec <- recipe(x1 ~ x3, data = ex_dat) %>%
     step_feature_hash(x3)
 
-  expect_error(rec_tr <- prep(rec), regex = NA)
+  expect_no_error(rec_tr <- prep(rec))
 
   res_tr <- bake(rec_tr, new_data = NULL, dplyr::starts_with("x3"))
 
@@ -241,9 +241,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
 
-  expect_error(
-    bake(rec, new_data = ex_dat),
-    NA
+  expect_no_error(
+    bake(rec, new_data = ex_dat)
   )
 })
 

tests/testthat/test-pca_sparse.R

@@ -231,9 +231,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
 
-  expect_error(
-    bake(rec, new_data = cells),
-    NA
+  expect_no_error(
+    bake(rec, new_data = cells)
   )
 })
 

tests/testthat/test-pca_sparse_bayes.R

@@ -240,9 +240,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
 
-  expect_error(
-    bake(rec, new_data = cells),
-    NA
+  expect_no_error(
+    bake(rec, new_data = cells)
   )
 })
 

tests/testthat/test-pca_truncated.R

@@ -207,9 +207,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
 
-  expect_error(
-    bake(rec, new_data = cells),
-    NA
+  expect_no_error(
+    bake(rec, new_data = cells)
   )
 })
 

tests/testthat/test-umap.R

@@ -344,9 +344,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
 
-  expect_error(
-    bake(rec, new_data = mtcars),
-    NA
+  expect_no_error(
+    bake(rec, new_data = mtcars)
   )
 })
 

tests/testthat/test-woe.R

@@ -376,9 +376,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
 
-  expect_error(
-    bake(rec, new_data = ames),
-    NA
+  expect_no_error(
+    bake(rec, new_data = ames)
   )
 })