Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less noise #125

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Less noise #125

merged 4 commits into from
Nov 13, 2023

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Nov 10, 2023

This is a first pass at #124

This PR wraps suppressMessages() around several calls to tune_bayes() and friends in cases where we don't do anything with the messages anyway.

Also in this PR: removing some library(rlang) calls that are not needed anymore and resulted in a couple of lines of

The following object is masked from

`suppressMessage()` because we don't do anything with them
the messages are not as overwhelming in the interactive case but quite a lot otherwise
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👌👏

tests/testthat/_snaps/parsnip-model-formula.md Outdated Show resolved Hide resolved
@hfrick hfrick merged commit c9bdd3f into main Nov 13, 2023
5 checks passed
@hfrick hfrick deleted the less-noise branch November 13, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants