New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete check on `newdata` #87

Merged

hfrick merged 3 commits into main from newdata-check

Jul 27, 2024

Member

hfrick commented Jul 27, 2024 •

edited

Loading

This follows the logic of tidymodels/parsnip#879 for the predict() methods. For multi_predict() it follows tidymodels/parsnip#912.

This then also closes #76.

The tests in extratests test-glmnet-poisson.R also run fine.

hfrick added 3 commits

July 27, 2024 10:58


          the check is already carried out via predict()

cda9b61


          the check is already carried out via multi_predict()

493343a


          Update NEWS

5d73ccf

hfrick merged commit cd303db into main

11 checks passed

hfrick deleted the newdata-check branch

July 27, 2024 10:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet