link to info on model formulas in error message #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
commented
Nov 6, 2023
| @@ -279,9 +279,11 @@ inline_check <- function(x) { | |||
| cli::cli_abort(c( | |||
| x = "No in-line functions should be used here.", | |||
| i = "{cli::qty(length(funs))}The following function{?s} {?was/were} \\ | |||
There was a problem hiding this comment.
In order to not increase the number of i entries further, I opted to collapse the itemization onto the line where it's introduced. I believe this happens in a few other places in recipes already!
|
dev deployment of those docs are here! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on tidymodels/parsnip#1015, where I put together a help-page on model formulas that we could link to throughout tidymodels errors and docs. I think this check would be a great place to spot folks who need this information but haven't found it yet.
Made sure to think through the "cascade" when putting these PRs together. With merging this PR as-is, this would put as at:
and, independently,