-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings2factors #1376
Strings2factors #1376
Conversation
Merge branch 'main' into strings2factors # Conflicts: # man/roles.Rd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good so far. Can you also add a bullet to the news file and document this change in behavior for prep.recipe()
? thank you
I also ran a revdepcheck on this PR and nothing bad happened |
Co-authored-by: Emil Hvitfeldt <[email protected]>
Looks good! thank you for doing this! |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
This is a possible fix for #1358 .
get_levels()
for any columns that do not have the roles "outcome" or "predictor".list(values = NA, ordered = NA)
Sorry for the annoying whitespace changes. I think there's only a few.