Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider relocating tests for tune_args() and tunable() #194

Open
simonpcouch opened this issue Feb 16, 2023 · 2 comments
Open

consider relocating tests for tune_args() and tunable() #194

simonpcouch opened this issue Feb 16, 2023 · 2 comments

Comments

@simonpcouch
Copy link
Contributor

As an additional comment... there are tests for tune_args() and tunable() methods in extratests:

do you think it's worth consolidating them with the tests here?

Originally posted by @hfrick in #193 (review)

@DavisVaughan
Copy link
Member

I think they are fine here because you only need workflows Imports/Suggests to test them and they are specific to workflows itself

@hfrick
Copy link
Member

hfrick commented Feb 20, 2023

I think we needed the tests to be in extratests during the transition period of the various methods (or at least it was easier). I meant more "moving tests into workflows" rather than the other direction - if there's anything in those tests in extratests that isn't covered here already.

topepo added a commit that referenced this issue Dec 2, 2024
* add postprocessors to tunable

* units tests for tunable postproc and some work on #194

* required for calibration

* Update tests/testthat/test-generics.R

Co-authored-by: Simon P. Couch <[email protected]>

---------

Co-authored-by: Simon P. Couch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants