Let additional arguments pass from db_compute.DBIConnection() to dbplyr_save_query() #1037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailored backends may want to support additional arguments in
compute()
. Unfortunatelydb_compute.DBIConnection
is not passing all arguments todbplyr_save_query()
and therefore additional arguments never reach thesql_query_save()
-method.For example,
overwrite
argument is not supported in dbplyr (#488). Adding it to tailored backend is more complicated than necessary as additional arguments are not passed through the whole chain fromcompute()
tosql_query_save
-method (see duckdb/duckdb#5115).Fix seems to be easy and non harmful. If that is not the case and/or there is a reason for not letting arguments pass through, please close this PR.