Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition expect_error() for snowflake backend #1547

Merged
merged 3 commits into from
Oct 31, 2024
Merged

transition expect_error() for snowflake backend #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6c7314
transition `expect_error()`
simonpcouch Oct 21, 2024
9c5355c
update error class in snaps
simonpcouch Oct 21, 2024
ab5ca80
`unsupported_arg_error` -> `dbplyr_error_unsupported_arg`
simonpcouch Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/utils-check.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ check_unsupported_arg <- function(x,

msg <- c(msg, i = allow_msg)
}
cli_abort(msg, call = call)
cli_abort(msg, call = call, class = "dbplyr_error_unsupported_arg")
}

stop_unsupported_function <- function(f, ..., with = NULL, call = caller_env()) {
Expand Down
25 changes: 25 additions & 0 deletions tests/testthat/_snaps/backend-snowflake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,28 @@
# pasting translated correctly

Code
test_translate_sql(paste0(x, collapse = ""))
Condition
Error in `check_collapse()`:
! `collapse` not supported in DB translation of `paste()`.
i Please use `str_flatten()` instead.

# difftime is translated correctly

Code
test_translate_sql(difftime(start_date, end_date, units = "auto"))
Condition
Error in `difftime()`:
! The only supported value for `units` on SQL backends is "days"

---

Code
test_translate_sql(difftime(start_date, end_date, tz = "UTC", units = "days"))
Condition
Error in `difftime()`:
! The `tz` argument is not supported for SQL backends.

# pmin() and pmax() respect na.rm

Code
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/rows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
(expect_error(rows_insert(lf, lf, by = "x", conflict = "error", in_place = FALSE))
)
Output
<error/rlang_error>
<error/dbplyr_error_unsupported_arg>
Error in `rows_insert()`:
! `conflict = "error"` isn't supported on database backends.
i It must be "ignore" instead.
Expand Down
6 changes: 3 additions & 3 deletions tests/testthat/_snaps/translate-sql-conditional.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@
(expect_error(test_translate_sql(case_when(x == 1L ~ "yes", .ptype = character())))
)
Output
<error/rlang_error>
<error/dbplyr_error_unsupported_arg>
Error in `case_when()`:
! Argument `.ptype` isn't supported on database backends.
Code
(expect_error(test_translate_sql(case_when(x == 1L ~ "yes", .size = 1))))
Output
<error/rlang_error>
<error/dbplyr_error_unsupported_arg>
Error in `case_when()`:
! Argument `.size` isn't supported on database backends.

Expand Down Expand Up @@ -122,7 +122,7 @@
Code
(expect_error(test_translate_sql(case_match(x, 1 ~ 1, .ptype = integer()))))
Output
<error/rlang_error>
<error/dbplyr_error_unsupported_arg>
Error in `case_match()`:
! Argument `.ptype` isn't supported on database backends.

Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/verb-pivot-wider.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
Code
(expect_error(tidyr::pivot_wider(df, id_expand = TRUE)))
Output
<error/rlang_error>
<error/dbplyr_error_unsupported_arg>
Error in `tidyr::pivot_wider()`:
! `id_expand = TRUE` isn't supported on database backends.
i It must be FALSE instead.
Expand Down
22 changes: 17 additions & 5 deletions tests/testthat/test-backend-snowflake.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test_that("pasting translated correctly", {
expect_equal(test_translate_sql(str_c(x, y)), sql("CONCAT_WS('', `x`, `y`)"))
expect_equal(test_translate_sql(str_c(x, y, sep = "|")), sql("CONCAT_WS('|', `x`, `y`)"))

expect_error(test_translate_sql(paste0(x, collapse = "")), "`collapse` not supported")
expect_snapshot(error = TRUE, test_translate_sql(paste0(x, collapse = "")))

expect_equal(test_translate_sql(str_flatten(x), window = TRUE), sql("LISTAGG(`x`, '') OVER ()"))
expect_equal(test_translate_sql(str_flatten(x, collapse = "|"), window = TRUE), sql("LISTAGG(`x`, '|') OVER ()"))
Expand Down Expand Up @@ -87,7 +87,10 @@ test_that("custom lubridate functions translated correctly", {
))
expect_equal(test_translate_sql(quarter(x)), sql("EXTRACT('quarter', `x`)"))
expect_equal(test_translate_sql(quarter(x, with_year = TRUE)), sql("(EXTRACT('year', `x`) || '.' || EXTRACT('quarter', `x`))"))
expect_error(test_translate_sql(quarter(x, fiscal_start = 2)))
expect_error(
test_translate_sql(quarter(x, fiscal_start = 2)),
class = "dbplyr_error_unsupported_arg"
)
expect_equal(test_translate_sql(isoyear(x)), sql("EXTRACT('year', `x`)"))

expect_equal(test_translate_sql(seconds(x)), sql("INTERVAL '`x` second'"))
Expand All @@ -106,7 +109,10 @@ test_that("custom clock functions translated correctly", {
local_con(simulate_snowflake())
expect_equal(test_translate_sql(add_years(x, 1)), sql("DATEADD(YEAR, 1.0, `x`)"))
expect_equal(test_translate_sql(add_days(x, 1)), sql("DATEADD(DAY, 1.0, `x`)"))
expect_error(test_translate_sql(add_days(x, 1, "dots", "must", "be empty")))
expect_error(
test_translate_sql(add_days(x, 1, "dots", "must", "be empty")),
class = "rlib_error_dots_nonempty"
)
expect_equal(test_translate_sql(date_build(2020, 1, 1)), sql("DATE_FROM_PARTS(2020.0, 1.0, 1.0)"))
expect_equal(test_translate_sql(date_build(year_column, 1L, 1L)), sql("DATE_FROM_PARTS(`year_column`, 1, 1)"))
expect_equal(test_translate_sql(get_year(date_column)), sql("DATE_PART(YEAR, `date_column`)"))
Expand All @@ -119,8 +125,14 @@ test_that("difftime is translated correctly", {
expect_equal(test_translate_sql(difftime(start_date, end_date, units = "days")), sql("DATEDIFF(DAY, `end_date`, `start_date`)"))
expect_equal(test_translate_sql(difftime(start_date, end_date)), sql("DATEDIFF(DAY, `end_date`, `start_date`)"))

expect_error(test_translate_sql(difftime(start_date, end_date, units = "auto")))
expect_error(test_translate_sql(difftime(start_date, end_date, tz = "UTC", units = "days")))
expect_snapshot(
error = TRUE,
test_translate_sql(difftime(start_date, end_date, units = "auto"))
)
expect_snapshot(
error = TRUE,
test_translate_sql(difftime(start_date, end_date, tz = "UTC", units = "days"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expectg_error(class = "unsupported_arg_error")?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, should have called this out in a self-review—these two lines transition from expect_error() to expect_snapshot() for one-off, unclassed errors where we're interested in testing the message specifically.

)
})

test_that("min() and max()", {
Expand Down
Loading