Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unite works for empty selections #1570

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

catalamarti
Copy link
Contributor

fixes #1548

Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Nice fix, this should be a good improvement for this edge case

tests/testthat/test-unite.R Outdated Show resolved Hide resolved
tests/testthat/test-unite.R Outdated Show resolved Hide resolved
tests/testthat/test-unite.R Show resolved Hide resolved
R/unite.R Show resolved Hide resolved
@DavisVaughan DavisVaughan merged commit 1c0653d into tidyverse:main Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message for empty tidyselect quosure
2 participants