Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipes 1.1.0 post #697

Merged
merged 7 commits into from
Jul 8, 2024
Merged

add recipes 1.1.0 post #697

merged 7 commits into from
Jul 8, 2024

Conversation

EmilHvitfeldt
Copy link
Collaborator

@EmilHvitfeldt EmilHvitfeldt commented Jun 11, 2024

content/blog/recipes-1-1-0/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super stoked for this release to hit CRAN! :)

The word "specify" feels like it's used rather loosely in this post. Does that refer specifically to a call to recipe(), or any calls to functions that happen before prep()?

In general, tidyteam authors end the last sentence or clause before a code block with . or :, with some variation between authors. This post uses ., ;, ,, or no punctuation at all rather freely. Could you standardize that approach here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cookies!!!😍🍪

content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some cool new features!

content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
content/blog/recipes-1-1-0/index.Rmd Outdated Show resolved Hide resolved
prep()

rec_spec %>%
bake(data_unseen)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resulting warning has a stray \ in it, before the word before:

#> Warning: ! There are new levels in x: "c".
#> ℹ Consider using step_novel() (?recipes::step_novel()) \ before
#> step_dummy() to handle unseen values.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in tidymodels/recipes#1346

cheating and rendering with that version to avoid this

@EmilHvitfeldt EmilHvitfeldt merged commit 5317c7a into main Jul 8, 2024
4 checks passed
@EmilHvitfeldt EmilHvitfeldt deleted the recipes-1-1-0 branch July 8, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants