feat!: change protobuf definitions #26
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| @@ -59,7 +59,7 @@ proto_builds = [ | |||
| [tool.black] | |||
| line-length = 88 | |||
| target-version = [ | |||
| 'py38', | |||
| 'py311', | |||
There was a problem hiding this comment.
Noticed that otaclient-iot-logging-server set the target version as python3.11, thus modified.
| uint64 timestamp = 2; | ||
| LogLevel level = 3; | ||
| string data = 4; | ||
| string ecu_id = 1; // target ECU ID |
There was a problem hiding this comment.
ecu_id is necessary as input because it is used to set log stream.
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| syntax = "proto3"; | |||
|
|
|||
| service OtaClientLoggingService { | |||
| service OtaClientIoTLoggingService { | |||
airkei
force-pushed
the
feat/fix_protobuf
branch
from
6a76b9f to
1773302
Compare
airkei
changed the title
airkei
force-pushed
the
feat/fix_protobuf
branch
from
1773302 to
af04d59
Compare
| string ecu_id = 1; // target ECU ID | ||
| LogType log_type = 2; // log type | ||
| string message = 3; // log message |
There was a problem hiding this comment.
At first, try to include level and timestamp fields.
But reconsider that it will be better to handle them in ota-client side(= otaclient-iot-logging-server doesn't care about log contents, level, and timestamp at all).
So removed these fields.
This realizes to change log format as necessary in ota-client without changing this repo.
What do you think?
| - name: Build otaclient IoT logging server proto package | ||
| run: | | ||
| pushd proto | ||
| hatch build -t wheel | ||
| popd | ||
| cp proto/dist/*.whl dist |
There was a problem hiding this comment.
new part to build protobuf.
There was a problem hiding this comment.
copied these files as v1 like ota-client.
airkei
force-pushed
the
feat/fix_protobuf
branch
from
af04d59 to
5c597d2
Compare
|
Why
https://tier4.atlassian.net/browse/RT4-13461
This PR is a part of protobuf support, this PR changes the protobuf definitions which will be used between
ota-clientandotaclient-iot-logging-server.The initial implementation was merged in #23. This protobuf is still not used/released at the moment, thus safe to change without taking care of the backward compatibility.
What
src/otaclient_iot_logging_server/v1/Test
No test because this PR just changes the protobuf, doesn't change the behavior at all.