Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UNKNOWN for traffic light color/shape in TrafficSignalState #1219

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Apr 1, 2024

Description

Abstract

Previously, there was no way to specify UNKNOWN for color/shape in traffic light state other than specifying directly to APIs in C++.
In this pull-request, scenario_simulator_v2 started to suppot specifying them in the scenarios.

Background

To test the behavior of Autoware when the traffic light is in the UNKNOWN state.

References

https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_perception_msgs/msg/TrafficSignalElement.msg#L2

Copy link

github-actions bot commented Apr 1, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo changed the title Support for traffic light color/shape in TrafficSignalState Support UNKNOWN for traffic light color/shape in TrafficSignalState Apr 1, 2024
@HansRobo HansRobo added wait for regression test bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 labels Apr 1, 2024
@HansRobo HansRobo self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant