Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_localization_msgs): remove unused depend in packages.xml files #105

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Sep 28, 2023

Related Links

autowarefoundation/autoware.universe#3606

Description

result of unused.sh (autowarefoundation/autoware#3468)

--- Checking src/universe/external/tier4_autoware_msgs/tier4_localization_msgs/package.xml ---
builtin_interfaces seems not to be used

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

…ml files

Signed-off-by: yamato-ando <Yamato ANDO>
@YamatoAndo
Copy link
Contributor Author

@mitsudome-r @VRichardJP I noticed this PR.
Since it is a duplicate, it is okay to close my PR.

@YamatoAndo
Copy link
Contributor Author

@mitsudome-r

@YamatoAndo
Copy link
Contributor Author

@mitsudome-r @mitsudome-r

@VRichardJP
Copy link

@YamatoAndo
No problem. Mine is a bit old and I don't have much time to follow it up.
Actually if you could take over I would be more than happy ;-)

@YamatoAndo
Copy link
Contributor Author

@VRichardJP OK! I'll take over it!

@YamatoAndo
Copy link
Contributor Author

@mitsudome-r @mitsudome-r @mitsudome-r

@yukkysaito
Copy link
Collaborator

@YamatoAndo could you resolve conflicts?

@YamatoAndo
Copy link
Contributor Author

YamatoAndo commented Jul 12, 2024

@yukkysaito Hi, I have resolved! Thank you!

Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito merged commit 4b137c5 into tier4/universe Jul 12, 2024
10 checks passed
@yukkysaito yukkysaito deleted the refactor/tier4_localization_msgs_remove_unused_depend branch July 12, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants