Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deepen/download_annotations): minor fix for more user friendly tool #181

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

kminoda
Copy link
Collaborator

@kminoda kminoda commented Dec 18, 2024

Description

Minor refactoring for deepen/download_annotations

How to review

Please follow the document to run the download_annotations script.

How to test

test data

task: convert_deepen_to_t4
description:
  visibility:
    full: "No occlusion of the object."
    most: "Object is occluded, but by less than 50%."
    partial: "The object is occluded by more than 50% (but not completely)."
    none: "The object is 90-100% occluded and no points/pixels are visible in the label."
  camera_index:
    CAM_FRONT: 0
    CAM_FRONT_RIGHT: 1
    CAM_BACK_RIGHT: 2
    CAM_BACK: 3
    CAM_BACK_LEFT: 4
    CAM_FRONT_LEFT: 5

conversion:
  input_base: ./data/non_annotated_t4_format
  input_anno_file: ./data/deepen_format/hoge.json
  input_bag_base: ./data/rosbag2
  output_base: ./data/t4_format
  topic_list: ./config/topic_list.yaml
  ignore_interpolate_label: False
  dataset_corresponding:
    fuga: ng9nuEQJstFE7X783rxSqXMc
$ python3 -m perception_dataset.deepen.download_annotations --config config/convert_deepen_to_t4_sample.yaml

And you would get

Requesting annotated json for:  ['ng9nuEQJstFE7X783rxSqXMc']
Annotation file is saved: ././data/deepen_format/lidar_annotations_accepted_deepen.json

Reference

None

Notes for reviewer

None

@kminoda kminoda requested a review from Shin-kyoto December 18, 2024 00:57
Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I did NOT check this PR by running the code.

@kminoda kminoda merged commit cc6c017 into main Dec 18, 2024
5 checks passed
@kminoda kminoda deleted the refactor/deepen_download/use_friendly_code branch December 18, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants