Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GML-1774: avoid using hardcoded ip #211

Merged
merged 5 commits into from
Jun 21, 2024
Merged

GML-1774: avoid using hardcoded ip #211

merged 5 commits into from
Jun 21, 2024

Conversation

billshitg
Copy link
Contributor

@billshitg billshitg commented Jun 20, 2024 •
edited
Loading

Code change:

  • Use nginx proxy to route the request from frontend to backend
  • Change FQN to relative paths in the react app

Test:

@billshitg billshitg self-assigned this Jun 20, 2024
@billshitg billshitg force-pushed the GML-1774-hardcoded-ip branch from b24c755 to 1d621ca Compare June 20, 2024 21:59
@billshitg billshitg merged commit 3195780 into dev Jun 21, 2024
1 check passed
@billshitg billshitg deleted the GML-1774-hardcoded-ip branch June 21, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobRossmiller-TG RobRossmiller-TG RobRossmiller-TG approved these changes

@ahmed-tg ahmed-tg ahmed-tg approved these changes

@neotericmedia neotericmedia Awaiting requested review from neotericmedia

@JextraInc JextraInc Awaiting requested review from JextraInc

Assignees

@billshitg billshitg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billshitg @ahmed-tg @RobRossmiller-TG