Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gml 1852 performant doc ingestion pipeline in support ai #264

Merged

Conversation

luzhoutg
Copy link
Contributor

No description provided.

Copy link
Contributor

@RobRossmiller-TG RobRossmiller-TG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the one change regarding drop_old. Please delete old code instead of commenting it out.

There's a lot of duplication between this package and graphrag. In the future, it'd be good to have a common set of functions that both loaders can use. For example, make_headers is identical in both packages as well as the whole ecc_util.py module

eventual-consistency-service/app/supportai/util.py Outdated Show resolved Hide resolved
@luzhoutg
Copy link
Contributor Author

Looks good except for the one change regarding drop_old. Please delete old code instead of commenting it out.

There's a lot of duplication between this package and graphrag. In the future, it'd be good to have a common set of functions that both loaders can use. For example, make_headers is identical in both packages as well as the whole ecc_util.py module

@luzhoutg luzhoutg closed this Aug 20, 2024
@luzhoutg luzhoutg reopened this Aug 20, 2024
@luzhoutg
Copy link
Contributor Author

Looks good except for the one change regarding drop_old. Please delete old code instead of commenting it out.

There's a lot of duplication between this package and graphrag. In the future, it'd be good to have a common set of functions that both loaders can use. For example, make_headers is identical in both packages as well as the whole ecc_util.py module

removed all comment out code now. I will start to remove the duplicates after merging parker's and my PR to dev. it would be easier due to less conflicts.

@RobRossmiller-TG
Copy link
Contributor

removed all comment out code now. I will start to remove the duplicates after merging parker's and my PR to dev. it would be easier due to less conflicts.

Absolutely agreed! The comment was as much a note for us to come back to as anything.

@luzhoutg luzhoutg merged commit da05a4a into dev Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants