Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locate: fix the default settings of circuit breaker #1593

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 25, 2025

ref tikv/pd#8678
The default settings are wrong, the unit should be the second.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2025
@rleungx
Copy link
Member Author

rleungx commented Feb 25, 2025

/cc @Tema @okJiang

Copy link

ti-chi-bot bot commented Feb 25, 2025

@rleungx: GitHub didn't allow me to request PR reviews from the following users: tema, okJiang.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Tema @okJiang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 25, 2025
Copy link

ti-chi-bot bot commented Feb 25, 2025

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, MyonKeminta, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,bufferflies]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
Copy link

ti-chi-bot bot commented Feb 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-25 10:07:37.013447892 +0000 UTC m=+350404.966606159: ☑️ agreed by bufferflies.
  • 2025-02-25 10:16:41.454576603 +0000 UTC m=+350949.407734867: ☑️ agreed by MyonKeminta.

@ti-chi-bot ti-chi-bot bot merged commit ad47ad6 into tikv:master Feb 25, 2025
11 checks passed
@rleungx rleungx deleted the fix-default-setting branch February 25, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants