[close #782] bump grpc to 1.60.0 #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
============================================
- Coverage 34.98% 34.81% -0.17%
+ Complexity 1362 1354 -8
============================================
Files 266 266
Lines 14274 14283 +9
Branches 1606 1606
============================================
- Hits 4994 4973 -21
- Misses 8845 8873 +28
- Partials 435 437 +2 ☔ View full report in Codecov by Sentry. |
pingyu
approved these changes
Mar 28, 2024
jackjeyis
pushed a commit
to jackjeyis/client-java
that referenced
this pull request
Jun 3, 2024
Signed-off-by: b.tian <[email protected]>
shiyuhang0
added a commit
that referenced
this pull request
Jun 4, 2024
…ervice(#774) (#775) * add TwoPhaseCommitter new Constructor contains executorService(#774) Signed-off-by: b.tian <[email protected]> * [close #671] remove shadowing of netty && grpc (#781) Signed-off-by: b.tian <[email protected]> * [close #782] bump grpc to 1.60.0 (#783) Signed-off-by: b.tian <[email protected]> * [close #774]remove redundant code --------- Signed-off-by: b.tian <[email protected]> Co-authored-by: b.tian <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: shi yuhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pull request bumps the gRPC version to 1.60.0 as the same deps of jetcd 0.7.7. Might related to grpc/grpc-java#9340
I can reproduce the memory leak while using gRPC 1.48.0 as described in issue #782. When I bump the gRPC to 1.60.0 the error logs disappear even I run the test 100 times.
Issue Number: close #782
What has changed and how does it work?
Bump the gRPC version to 1.60.0.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes