Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] 8.5: add etcd key compatibility test #9125

Open
wants to merge 14 commits into
base: release-8.5
Choose a base branch
from

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Mar 7, 2025

What problem does this PR solve?

Issue Number: Close #xxx

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. labels Mar 7, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiuyesuifeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 7, 2025
okJiang added 4 commits March 7, 2025 18:15
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
@purelind
Copy link
Contributor

purelind commented Mar 8, 2025

/test ?

Copy link
Contributor

ti-chi-bot bot commented Mar 8, 2025

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/release-8.5/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@purelind
Copy link
Contributor

purelind commented Mar 8, 2025

/test build

okJiang added 3 commits March 10, 2025 10:48
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Mar 10, 2025

/retest

okJiang added 3 commits March 10, 2025 11:21
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Mar 10, 2025

/retest

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.59%. Comparing base (2da8160) to head (2deab4c).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.5    #9125      +/-   ##
===============================================
+ Coverage        75.58%   75.59%   +0.01%     
===============================================
  Files              462      462              
  Lines            72389    72429      +40     
===============================================
+ Hits             54715    54753      +38     
+ Misses           14176    14166      -10     
- Partials          3498     3510      +12     
Flag Coverage Δ
unittests 75.59% <84.78%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Mar 10, 2025

/retest

1 similar comment
@okJiang
Copy link
Member Author

okJiang commented Mar 10, 2025

/retest

Signed-off-by: okJiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants