Merge pull request #38 from tilde-nlp/fix/adding-seo-elements

Fix/adding seo elements
tilde-nlp · Oct 17, 2024 · d28ade0 · d28ade0
2 parents d0e690a + 24b0b6d
commit d28ade0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 38 deletions.
diff --git a/src/js/lib/AsyncTranslator.ts b/src/js/lib/AsyncTranslator.ts
@@ -260,7 +260,7 @@ class AsyncTranslator {
           translatableItem: element,
           type: element.type,
           attributeName: null,
-          description: null,
+          description: element.type === TranslatableItemType.ELEMENT ? null : element.startMarker.parentElement.tagName,
           text: this.minimizeText(element.html),
           tagName: element.startMarker.parentElement.tagName
         }

diff --git a/src/js/lib/DOMTranslation.ts b/src/js/lib/DOMTranslation.ts
@@ -976,8 +976,10 @@ class DOMTranslation {
       }
     }
     for (const range of translationRanges) {
+      const isSeo = TranslationElementCandidates.get(range.startMarker.parentElement.tagName)?.type === TranslatableItemType.ELEMENT_SEO;
+
       range.visibleInCurrentView = DOMExtensions.elementIsVisible(range.startMarker, this.registredIframes)
-      range.type = TranslatableItemType.ELEMENT
+      range.type = isSeo ? TranslatableItemType.ELEMENT_SEO : TranslatableItemType.ELEMENT
       range.html = this.cropAndMinifyTranslationRange(range, translatableElements, range.startMarker, range.startMarker, range.endMarker)
     }
 

diff --git a/src/js/lib/TranslationElementCandidates.ts b/src/js/lib/TranslationElementCandidates.ts
@@ -9,41 +9,5 @@ export const TranslationElementCandidates = new Map<string, IElementCandidate>([
     {
       type: TranslatableItemType.ELEMENT_SEO
     }
-  ],
-  [
-    'H1',
-    {
-      type: TranslatableItemType.ELEMENT_SEO
-    }
-  ],
-  [
-    'H2',
-    {
-      type: TranslatableItemType.ELEMENT_SEO
-    }
-  ],
-  [
-    'H3',
-    {
-      type: TranslatableItemType.ELEMENT_SEO
-    }
-  ],
-  [
-    'H4',
-    {
-      type: TranslatableItemType.ELEMENT_SEO
-    }
-  ],
-  [
-    'H5',
-    {
-      type: TranslatableItemType.ELEMENT_SEO
-    }
-  ],
-  [
-    'H6',
-    {
-      type: TranslatableItemType.ELEMENT_SEO
-    }
   ]
 ])