-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
towards v1.10.0 [BREAKING] #263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change in header de-duplication * enforce utf8 encoding * more code refactoring
* restructure tests * improve tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of Code and Tests
Performance Improvements
Previous versions of SmarterCSV applied some header transformations when
user_provided_headers
were provided.This legacy behavior does not make much sense, because when
user_provided_headers
are given, we can assume they are correct, and should be used as-is.For the unlikely scenario that incorrect
user_provided_headers
were given, the legacy code attempted to disambiguate them, by applying a suffix.strings_as_keys
transformations were applied touser_provided_headers
This legacy behavior does not make much sense, because when
user_provided_headers
are given, we can assume they are correct, and should be used as-is.BREAKING CHANGES:
when
user_provided_headers
are provided:strings_as_keys
options will be ignoredoption
duplicate_header_suffix
now defaults to''
instead ofnil
.nil
to get the behavior from previous versions.