Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify shard and drain label keys #431

Closed
timebertt opened this issue Jan 19, 2025 · 0 comments · Fixed by #441
Closed

Simplify shard and drain label keys #431

timebertt opened this issue Jan 19, 2025 · 0 comments · Fixed by #441
Assignees
Labels
enhancement New feature or request

Comments

@timebertt
Copy link
Owner

timebertt commented Jan 19, 2025

What would you like to be added:

Currently, the shard and drain label keys follow this pattern:

{shard,drain}.alpha.sharding.timebertt.dev/clusterring-<hash>-<clusterring-name>

With #429, the clusterring- part is dropped, because there is no need to distinguish between different ring kinds.

Let's further simplify the key pattern to this:

{shard,drain}.alpha.sharding.timebertt.dev/<controllerring-name>

For this, we need to restrict the name of ControllerRing objects not to be longer than 63 characters.

Why is this needed:

The label key part after the / must not exceed 63 characters.
That's why the hash was added, i.e., to distinguish between ClusterRing objects with names longer than 63 characters.

This is too complicated for the fact that such long names are rather an edge case.
Let's exclude such edge cases using validation in favor of a simplified developer experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
1 participant