Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ControllerRing name length, simplify shard/drain label keys, simplify webhook name #441

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

timebertt
Copy link
Owner

What this PR does / why we need it:

This PR introduces a limit on the ControllerRing length, so that we can simplify the shard and drain labels.
On the way, we simplify the webhook name in the same way.

⚠️ Please consult the updated documentation and examples for how to adapt to this breaking change.

  • The ControllerRing name must not be longer than 63 characters.
  • The shard and drain label keys have been simplified to {shard,drain}.alpha.sharding.timebertt.dev/<controllerring-name>.
  • The MutatingWebhookConfiguration name has been simplified to controllerring-<controllerring-name>.
  • There is no migration path available.

Which issue(s) this PR fixes:
Fixes #431

Special notes for your reviewer:

@timebertt timebertt added the breaking This PR contains a breaking change and should be listed accordingly in release notes. label Jan 27, 2025
@timebertt timebertt enabled auto-merge (squash) January 27, 2025 21:38
@timebertt timebertt merged commit cd5eb84 into main Jan 27, 2025
4 checks passed
@timebertt timebertt deleted the simplify-labels branch January 27, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This PR contains a breaking change and should be listed accordingly in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify shard and drain label keys
1 participant