Fix potential int overflow in merge chunks #7603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging chunks, a relation size calculation could potentially overflow an 32-bit integer value. Use a 64-bit integer for the result to prevent overflow.
mkindahl
approved these changes
Jan 20, 2025
| if (forkNumber == MAIN_FORKNUM) | ||
| return merge_rel_nblocks * BLCKSZ; | ||
| return nblocks * BLCKSZ; |
There was a problem hiding this comment.
An option is to just add a cast.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7603 +/- ##
==========================================
+ Coverage 80.06% 82.29% +2.23%
==========================================
Files 190 238 +48
Lines 37181 44140 +6959
Branches 9450 11101 +1651
==========================================
+ Hits 29770 36327 +6557
- Misses 2997 3430 +433
+ Partials 4414 4383 -31 ☔ View full report in Codecov by Sentry. |
|
@mkindahl, @antekresic: please review this pull request.
|
|
Pushed this to Coverity and the report looks clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging chunks, a relation size calculation could potentially overflow an 32-bit integer value. Use a 64-bit integer for the result to prevent overflow.
Disable-check: force-changelog-file
Disable-check: approval-count