-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to tailwind v4 #1122
base: main
Are you sure you want to change the base?
Conversation
@dandedotdev is attempting to deploy a commit to the timlrx's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'd like to apologize for my carelessness. Thank you for checking the actual applied styles for me. In 03a8ec5, I revised the selector for & :where(code):not(.code-highlight) I think it might be better than: & :where(code):not(pre code)
However, if the template migrates to another code-highlighting tool in the future, this might not work. (The classname is added by the generator of rehype-prism-plus.) I also took the screenshots:
Thank you again for your kindness and attention. I'll spend more time making the output CSS of both settings the same. |
After scanning the output file of Tailwind v4, I found some use of I also corrected a mistake I made, in the content in the original module.exports = {
theme: {
extend: {
typography: ({ theme }) => ({
DEFAULT: {
// ...
invert: { // HERE
// ...
},
}),
},
},
plugins: [require('@tailwindcss/forms'), require('@tailwindcss/typography')],
} ...is for There are still a few differences between the Tailwind output of my PR and that of the main branch. Sadly, for now, there is no way to get a similar output of |
Thank you for developing the template. I really appreciate it.
Recently, I spent some time migrating my website to Tailwind v4 so I think maybe I can try contributing to the template.
I put these styles at the
utilities
layer because theprose
provided by@tailwind/typography
is also at this layer so that would be easier.Thank you for your time and attention.