Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss] Paper Edits #80

Merged
merged 13 commits into from
Nov 1, 2024
Merged

[joss] Paper Edits #80

merged 13 commits into from
Nov 1, 2024

Conversation

timothyas
Copy link
Owner

Incorporates:

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (1524713) to head (9d99a15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          11       11           
  Lines        1029     1029           
=======================================
  Hits          990      990           
  Misses         39       39           
Flag Coverage Δ
unittests 96.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sneakers-the-rat sneakers-the-rat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even tho i have some comments on the figure in the other issue, i'm just gonna give you approval on this PR to give the gift of green checkmark as a thanks for receiving my suggestions gracefully and applying the ones that made sense to apply. I do think one more round on the figure would get it there :)

@timothyas
Copy link
Owner Author

Closes #78 #79

Thanks @sneakers-the-rat again for all the comments!

@timothyas timothyas merged commit 71c280c into main Nov 1, 2024
5 checks passed
@timothyas timothyas deleted the joss/paper-review branch November 1, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants