Created a method Query.Match that returns whether a query matches a data item. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zond
force-pushed
the
master
branch
3 times, most recently
from
dd3ab65 to
7f7609b
Compare
timshannon
requested changes
Feb 7, 2024
|
Sorry, my git expertise is lacking. It did point to your main branch when I created the PR, but since then I updated things to make it work locally. Does it look better now? |
|
Looks great. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a library that will provide subscription semantics to a badgerhold storage.
The subscriptions will be defined as "whatever matches a badgerhold Query".
To know if a subscriber should be updated when an insert/delete/update happens, I need to check if the item matches a Query.
The simplest way I could figure out of doing that is this PR.
What do you think, is this an acceptable solution? I'd be happy to discuss and modify my PR until you're happy with it.