Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBI 2716 & 2758 Improve Testimonials Section on Home Page #2756

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ZenoWang1999
Copy link

@ZenoWang1999 ZenoWang1999 commented Jan 16, 2025

Resolves #2716

  • Updated the original component using Magic UI as required, change the display mode to an infinite scrolling component
  • Limit the height to a fixed size, and keep the rest of the basic functionality unchanged
  • Optimized the white transition effect to a transparent transition.

image
Figure: New layout implemented using magic ui

image
Figure: The basic functionality remains unchanged

Resolves #2758

  • Resolved the issues with right sidebar overflow and width fluctuation.
  • Added functionality for the right sidebar to scroll synchronously with the corresponding content in the middle.
  • Optimized the component appearance.

Please help me test whether the following content loads properly in your local environment:

  1. Start tina.io and visit http://localhost:3000/docs/introduction/faq.
  2. If it displays as shown in Figure 1, it indicates that the css content has loaded correctly.
  3. If it displays as shown in Figure 2, where the right sidebar does not hide the scrollbar, it indicates that the styled component failed to load. This issue often occurs after React Fast Refresh, and I am not yet sure whether the same issue appears in other local or production environments. If it does, I will replace this part of CSS with JSX.

image
Figure 1: Loading correctly

image
Figure 2: The styled component did not load.

General Contributing:

All New Content Submissions: (To be confirmed by reviewer)

  • Title is short & specific
  • Headers are logically ordered & consistent
  • Purpose of document is explained in the first paragraph
  • Procedures are tested and work
  • Any technical concepts are explained or linked to
  • Document follows structure from templates
  • All links work
  • The spelling and grammar checker has been run
  • Graphics and images are clear and useful
  • Any prerequisites and next steps are defined.

@ZenoWang1999 ZenoWang1999 requested a review from a team as a code owner January 16, 2025 07:24
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 1:58am

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ZenoWang1999
❌ tino-liu
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@joshbermanssw joshbermanssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments :) awesome component

components/blocks/Testimonial/Testimonials.tsx Outdated Show resolved Hide resolved
components/blocks/Testimonial/Testimonials.tsx Outdated Show resolved Hide resolved
components/blocks/Testimonial/Testimonials.tsx Outdated Show resolved Hide resolved
components/blocks/Testimonial/Testimonials.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@joshbermanssw joshbermanssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool - just a couple small comments

@isaaclombardssw
Copy link
Contributor

isaaclombardssw commented Jan 16, 2025

A couple of acceptance test thoughts – there's a white border here (it should be opacity gradient).

This component is used on another page (see below), the border around avatars might also not be suitable for that use case. Check with @landonmaxwell on that.

Also should this be limited to the standard max width for components?

SCR-20250117-jahv

SCR-20250117-iwrt

@isaaclombardssw
Copy link
Contributor

Looks dope 💯

@ZenoWang1999 ZenoWang1999 changed the title PBI 2716 Improve Testimonials Section on Home Page PBI 2716 && 2758 Improve Testimonials Section on Home Page Jan 20, 2025
@ZenoWang1999 ZenoWang1999 changed the title PBI 2716 && 2758 Improve Testimonials Section on Home Page PBI 2716 & 2758 Improve Testimonials Section on Home Page Jan 20, 2025
@isaaclombardssw
Copy link
Contributor

Deployment looks really good!

Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – great job on this one 🙌

components/AppRouterMigrationComponents/Docs/toc/index.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants