-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBI 2716 & 2758 Improve Testimonials Section on Home Page #2756
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments :) awesome component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool - just a couple small comments
A couple of acceptance test thoughts – there's a white border here (it should be opacity gradient). This component is used on another page (see below), the border around avatars might also not be suitable for that use case. Check with @landonmaxwell on that. Also should this be limited to the standard max width for components? |
Looks dope 💯 |
Deployment looks really good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM – great job on this one 🙌
Resolves #2716
Figure: New layout implemented using magic ui
Figure: The basic functionality remains unchanged
Resolves #2758
Please help me test whether the following content loads properly in your local environment:
Figure 1: Loading correctly
Figure 2: The styled component did not load.
General Contributing:
All New Content Submissions: (To be confirmed by reviewer)