Make relay init container script more resilient: #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! thanks @jacobweinstock ❤️ |
Things like left over interfaces shouldn't cause crashloops anymore. NOTE! When flipping between stack.relay.interfaceMode=macvlan and stack.relay.interfaceMode=ipvlan, the deployment strategy must be set to Recreate. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
broadcast-interface-resilence
branch
from
50a05d1 to
22e6d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Things like left over interfaces shouldn't cause crashloops anymore.
Note
If flipping between
stack.relay.interfaceMode=macvlanandstack.relay.interfaceMode=ipvlan, the deployment strategy must be set toRecreate. This is because of a limitation in being able to create both macvlan and ipvlan interfaces with the same parent at the same time on the same node.Why is this needed
Fixes: #110
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: