fixing kubevip documented value paths #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Deffenbaugh <[email protected]>
mddeff
force-pushed
the
fixing-chart-readme
branch
from
7d3ef79 to
9b806ff
Compare
jacobweinstock
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating docs to provide correct paths
Why is this needed
Fixes: #121
How Has This Been Tested?
I tested by adding
to my helm overrides and confirmed it disabled the kubevip deployment.
How are existing users impacted? What migration steps/scripts do we need?
If they were following the docs, no configurations were actually set.
Checklist:
I have: